[over.call.object] Fix surrogate calls with regards to cv-qualifiers #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Jun 3, 2019
jensmaurer
added
the
changes requested
Standardizes existing practice. All of GCC, Clang, MSVC, ICC in pedantic mode already behave as if all of these changes were made.
jensmaurer
removed
the
changes requested
jensmaurer
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizes existing practice. All of GCC, Clang, MSVC, ICC in pedantic mode already behave as if all of these changes were made.
Evidence for the above:
no method cv-qualifier: https://godbolt.org/z/C0AcCi
both method cv-qualifiers: https://godbolt.org/z/-zy4GY
const pointer: https://godbolt.org/z/EVQ781
volatile pointer: https://godbolt.org/z/tePbKG
const volatile pointer: https://godbolt.org/z/f-g1Ge
reference to const pointer: https://godbolt.org/z/uXEp-J
reference to volatile pointer: https://godbolt.org/z/l2KEs9
reference to const volatile pointer: https://godbolt.org/z/5Mhijc
Other justification for the first two (in document order) changes: it is unlikely to be Committee intent to permit surrogate calls only on conversion functions with exactly one cv-qualifier.