Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[algorithms.parallel.exec],[alg.set.operations],[alg.min.max],[alg.clibrary] remove empty parens #2925

Merged
merged 1 commit into from Jun 11, 2019

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Jun 11, 2019

When referring to a function, use its name, not a call expression.

…library] remove empty parens

When referring to a function, use its name, not a call expression.
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially when that call expression is ill-formed.

@jwakely
Copy link
Member Author

jwakely commented Jun 11, 2019

Right. The last one is especially bad:

Throws: Any exception thrown by compar()

... so it can't throw then, because compar() isn't even well-formed, right‽

This happens in other clauses too, but I'm just fixing one for now.

@jensmaurer jensmaurer merged commit 7830d39 into cplusplus:master Jun 11, 2019
@jwakely jwakely deleted the empty-parens branch January 22, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants