[range.filter.sentinel] Correct typo in constructor Effects #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwakely, are you ok with this change? |
jwakely
approved these changes
Jun 25, 2019
|
I agree it's currently broken, and I think the change represents what was always intended, so this qualifies as editorial for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2880.
Note that I'm once again stretching "editorial" to avoid burning LWG time. The existing specification is obviously incorrect - it would result in either an ill-formed program or stack overflow - but the fix is not quite as obviously correct. As always, feel free to call this non-editorial and I'll file an LWG issue instead.