Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INDEX] Ensure index entry for all Cpp17Requirements #2961

Closed

Conversation

AlisdairM
Copy link
Contributor

Ensure that each Cpp17Requirement that uses the \oldconcept markup
has one, and exactly one, usage close to its definition that uses
the \oldconceptdefn markup instead. This puts a consistent set of
entries with the Cpp17 prefix into the main index.

Note that there are existing, inconsistent, attempts to index these
requirements, with the container 'into' requirements appearing at
the top of the index due to a \defnx (and the markup somehow changing
the sort order) and most of the lib-intro requirements appearing as
sub-entries under 'Requirements'. This change-set updates the
\oldconceptdefn macro to use \defnx consistent with the containers
clause usage, producing a single consistent list that is out of place
w.r.t. the spelling, and does not refactor the mark-up for containers.

Ensure that each Cpp17Requirement that uses the \oldconcept markup
has one, and exactly one, usage close to its definition that uses
the \oldconceptdefn markup instead.  This puts a consistent set of
entries with the Cpp17 prefix into the main index.

Note that there are existing, inconsistent, attempts to index these
requirements, with the container 'into' requirements appearing at
the top of the index due to a \defnx (and the markup somehow changing
the sort order) and most of the lib-intro requirements appearing as
sub-entries under 'Requirements'.  This change-set updates the
\oldconceptdefn macro to use \defnx consistent with the containers
clause usage, producing a single consistent list that is out of place
w.r.t. the spelling, and does not refactor the mark-up for containers.
@AlisdairM
Copy link
Contributor Author

Confirmed at Cologne that this needs some reworking, so I am closing the PR to avoid clogging the list of PRs at a busy time, and ensuring no even minor risk of it accidentally landing. It will return once the C++20 ballot document is safely out for review.

@AlisdairM AlisdairM closed this Aug 3, 2019
@CaseyCarter
Copy link
Contributor

This puts a consistent set of
entries with the Cpp17 prefix into the main index.

Be forewarned that I plan to submit an editorial PR to strip the Cpp17 prefix from the names of the requirement sets post-CD. (We no longer need the prefix to avoid clashes with True Library Concepts now that the library concepts use snake_case.) If that change is approved, you'll need to modify your strategy if you want the new index entries all together.

@AlisdairM
Copy link
Contributor Author

Thanks Casey - I already have several ideas in hand for how I will handle that, but am in no rush until after the ballot CD is complete.

@AlisdairM AlisdairM deleted the index_cpp17_requirements branch November 14, 2023 19:28
@AlisdairM AlisdairM restored the index_cpp17_requirements branch November 14, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants