Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2019-07 LWG Motion 12] P1614R2 The Mothership has Landed #3016

Closed
jensmaurer opened this issue Jul 21, 2019 · 5 comments · Fixed by #3098
Closed

[2019-07 LWG Motion 12] P1614R2 The Mothership has Landed #3016

jensmaurer opened this issue Jul 21, 2019 · 5 comments · Fixed by #3098
Assignees
@jensmaurer
Milestone
post-2019-07

Comments

@jensmaurer
Copy link
Member

No description provided.

@jensmaurer
Copy link
Member Author

@Dani-Hub notes:

The newly added [cmp.concept] says:

"partially-ordered-with<T, U> is satisfied only if:" [bullet list of semantic requirements]

The usage of "satisfied" is inappropriate here and should be

"T and U model partially-ordered-with<T, U> only if:" [bullet list of semantic requirements]

@jensmaurer jensmaurer added this to the post-2019-07 milestone Jul 23, 2019
@jensmaurer
Copy link
Member Author

From P1452R2 On the non-uniform semantics of return-type-requirements:

"[If] P1614, “The Mothership Has Landed: Adding <=> to the Library”), replace said production with -> ConvertibleTo where Type is the type named by the trailing-return-type:"

This was referenced Jul 25, 2019
Merged
Merged
@jensmaurer jensmaurer self-assigned this Jul 29, 2019
@jensmaurer jensmaurer mentioned this issue Jul 29, 2019
Merged
zygoloid added a commit that referenced this issue Aug 5, 2019
@zygoloid
Merge 2019-07 LWG Motion 12
27cad22 
P1614R2 Adding <=> to the Library

Fixes #3016.
@Dani-Hub
Copy link
Member

Dani-Hub commented Aug 6, 2019

I couldn't find the resolution expressed in the second comment of this issue referring to [cmp.concept]'s notion of "partially-ordered-with<T, U> is satisfied only if:". Could you please help me understanding the decided resolution?

@JohelEGP
Copy link
Contributor

JohelEGP commented Aug 6, 2019

It is here:

draft/source/support.tex

Lines 4737 to 4738 in 4060676

\tcode{T} and \tcode{U} model
\tcode{\placeholder{partially-ordered-with}<T, U>} only if:

The resolution was to fix the wording to follow the convention.

@Dani-Hub
Copy link
Member

Dani-Hub commented Aug 6, 2019

Thanks for the pointer - looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
post-2019-07
Development

Successfully merging a pull request may close this issue.

P1614R2 Adding <=> to the Library cplusplus/draft
3 participants
@Dani-Hub @JohelEGP @jensmaurer