Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1208R6 Adopt source_location for C++20 #3037

Merged
merged 3 commits into from Aug 6, 2019
Merged

Conversation

jensmaurer
Copy link
Member

  • Changed stable name to [support.srcloc].
  • Added cross-references.
  • Changed "description" environment showing result values to a table

Fixes #3036.

@jensmaurer
Copy link
Member Author

@zygoloid, this might need more work.

  • Both the section headings "Creation" and "Field access" are novel.
  • The subclause nesting of "synopsis" inside "class source_location" is novel.
  • Showing values of exposition-only data members (as opposed to results of member function calls) differs from at least [tab:re.results.const].

Please advise.

@jwakely
Copy link
Member

jwakely commented Jul 22, 2019

Both the section headings "Creation" and "Field access" are novel.

We have subclauses called simply "Creation" e.g. [util.smartptr.shared.create] and [uniq.ptr.create], and we have "Tuple creation functions" [tuple.creation]. I don't like "fields" much. We use "observers" in some other places.

The subclause nesting of "synopsis" inside "class source_location" is novel.

And there are hanging paragraphs.

Showing values of exposition-only data members (as opposed to results of member function calls) differs from at least [tab:re.results.const].

The regex clause is not considered a model of good library wording :-) Tables showing postconditions in terms of member functions are used in many places, but if we do that, the Returns: elements in [reflection.src_loc.fields] probably need reworking.

The reason for the presentation in the R6 revision is that previous proposals had prose for the member functions saying "represented by this object" and it wasn't clear what the location represented by the object was (especially if not created by a call to current()). By introducing exposition-only data members and saying how they're initialized in p1 (1.1) that problem went away, and the Returns: elements in [reflection.src_loc.fields] were trivial to specify in terms of the data members.

@jwakely
Copy link
Member

jwakely commented Jul 22, 2019

To be clear, the table seems fine to me. I'm just trying to explain why the effects are stated in terms of the exposition-only data members rather than the member functions.

@burblebee burblebee self-assigned this Aug 3, 2019
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

source/support.tex Show resolved Hide resolved
source/support.tex Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
source/support.tex Show resolved Hide resolved
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two editorial corrections.

source/support.tex Outdated Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
@burblebee
Copy link
Contributor

@jensmaurer please fix the build

@jensmaurer
Copy link
Member Author

@burblebee: Looks like some timeout during the build; nothing I can fix:

47
15.36s$ docker pull godbyk/texlive-basic:latest
448
Error response from daemon: Get https://registry-1.docker.io/v2/godbyk/texlive-basic/manifests/latest: Get https://auth.docker.io/token?scope=repository%3Agodbyk%2Ftexlive-basic%3Apull&service=registry.docker.io: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
449
The command "docker pull godbyk/texlive-basic:latest" failed and exited with 1 during .

Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the last build passed :)

 - Changed stable name to [support.srcloc].
 - Added cross-references.
 - Changed "description" environment showing result values to a table
@zygoloid
Copy link
Member

zygoloid commented Aug 6, 2019

Some of the organization is novel, but the CD is already late so I'm not going to block on changing that.

@zygoloid zygoloid merged commit 4060676 into master Aug 6, 2019
@jensmaurer jensmaurer deleted the motions-2019-07-lwg-32 branch December 15, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2019-07 LWG Motion 32] P1208R6 Adopt source_location for C++20
5 participants