New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P1208R6 Adopt source_location for C++20 #3037
Conversation
@zygoloid, this might need more work.
Please advise. |
We have subclauses called simply "Creation" e.g. [util.smartptr.shared.create] and [uniq.ptr.create], and we have "Tuple creation functions" [tuple.creation]. I don't like "fields" much. We use "observers" in some other places.
And there are hanging paragraphs.
The regex clause is not considered a model of good library wording :-) Tables showing postconditions in terms of member functions are used in many places, but if we do that, the Returns: elements in [reflection.src_loc.fields] probably need reworking. The reason for the presentation in the R6 revision is that previous proposals had prose for the member functions saying "represented by this object" and it wasn't clear what the location represented by the object was (especially if not created by a call to |
To be clear, the table seems fine to me. I'm just trying to explain why the effects are stated in terms of the exposition-only data members rather than the member functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two editorial corrections.
@jensmaurer please fix the build |
@burblebee: Looks like some timeout during the build; nothing I can fix: 47 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the last build passed :)
- Changed stable name to [support.srcloc]. - Added cross-references. - Changed "description" environment showing result values to a table
421b11b
to
7f4e95e
Compare
describing it indirectly.
Some of the organization is novel, but the CD is already late so I'm not going to block on changing that. |
Fixes #3036.