Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1207R4 Movability of Single-pass Iterators #3049

Merged
merged 1 commit into from Aug 6, 2019
Merged

P1207R4 Movability of Single-pass Iterators #3049

merged 1 commit into from Aug 6, 2019

Conversation

burblebee
Copy link
Contributor

Fixes #3026.

@burblebee
Copy link
Contributor Author

To lwg: In change to [counted.iter.access], should "\returns" become "\effects Equivalent to:" to mimic change in P0896R4 (e85af95)?

jwakely
jwakely reviewed Jul 22, 2019
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem to be P1207R4 not P1638R1.

jwakely
jwakely requested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's the title of the commit message that's wrong. The reference to the issue for the motion is right.

@jwakely
Copy link
Member

jwakely commented Jul 22, 2019

To lwg: In change to [counted.iter.access], should "\returns" become "\effects Equivalent to:" to mimic change in P0896R4 (e85af95)?

I don't see any great need to do that here. Also I see that [is.sorted] p4 is wrong since that commit, it's missing a return.

@jwakely
Copy link
Member

jwakely commented Jul 22, 2019

To be clear: it's certainly not the case that all Returns: elements should be replaced by "Effects: Equivalent to:". They mean different things.

@burblebee
Copy link
Contributor Author

These changes seem to be P1207R4 not P1638R1.

Yup. I didn't know how to fix that without force-pushing, hopefully that was ok.

@jwakely jwakely changed the title P1638R1 basic_istream_view::iterator should not be copyable P1207R4 Movability of Single-pass Iterators Jul 22, 2019
jwakely
jwakely reviewed Jul 22, 2019
View reviewed changes
source/iterators.tex Outdated Show resolved Hide resolved
jwakely
jwakely reviewed Jul 22, 2019
View reviewed changes
source/iterators.tex Outdated Show resolved Hide resolved
@burblebee
Copy link
Contributor Author

... I see that [is.sorted] p4 is wrong since that commit, it's missing a return.

Don't think we should address that as part of this commit - please open a new issue?

jwakely
jwakely reviewed Jul 22, 2019
View reviewed changes
source/iterators.tex Outdated Show resolved Hide resolved
jwakely
jwakely requested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See three inline comments.

@jwakely
Copy link
Member

jwakely commented Jul 22, 2019 •
edited

... I see that [is.sorted] p4 is wrong since that commit, it's missing a return.

Don't think we should address that as part of this commit - please open a new issue?

Sure, I'm fixing it separately. See #3050

@burblebee burblebee requested a review from jwakely July 22, 2019 22:56
jwakely
jwakely requested changes Jul 23, 2019
View reviewed changes
source/iterators.tex Outdated Show resolved Hide resolved
CaseyCarter
CaseyCarter reviewed Jul 24, 2019
View reviewed changes
source/iterators.tex Outdated Show resolved Hide resolved
@burblebee burblebee requested a review from jwakely July 25, 2019 02:44
@zygoloid zygoloid merged commit 4152579 into master Aug 6, 2019
@jensmaurer jensmaurer deleted the motions-2019-07-lwg-22 branch December 15, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter left review comments

@jwakely jwakely jwakely approved these changes

Assignees

@jwakely jwakely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2019-07 LWG Motion 22] P1207R4 Movability of Single-pass Iterators
4 participants
@burblebee @jwakely @CaseyCarter @zygoloid