Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1523R1 Views and Size Types #3056

Merged
merged 1 commit into from Aug 6, 2019
Merged

P1523R1 Views and Size Types #3056

merged 1 commit into from Aug 6, 2019

Conversation

burblebee
Copy link
Contributor

Fixes #3034.

@burblebee
Copy link
Contributor Author

I used \hfull\break to work around an Overfull issue - what should I have used?

Also, shouldn't make-unsigned-like be introduced and explained somewhere? It first appears out of the blue in [range.prim.size]p1.3 (same for make-unsigned-like-t).

@jwakely
Copy link
Member

jwakely commented Jul 23, 2019

They're introduced in P1522R1.

source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of your uses of \placeholder in this change are similar to the uses where you changed to \placeholdernc. Did you make up your mind what looks better? Then, please be consistent.

@burblebee
Copy link
Contributor Author

Most of your uses of \placeholder in this change are similar to the uses where you changed to \placeholdernc. Did you make up your mind what looks better? Then, please be consistent.

I changed all added \placeholder{}s with \placeholdernc{}s to make you happy, but the surrounding Latex is inconsistent in its use of \placeholder v. \placeholdernc. We need to come up with some rules on which to use where, and do a global sweep to fix it.

Leave this unresolved so we'll know to create an issue for it.

@zygoloid
Copy link
Member

zygoloid commented Aug 5, 2019

Most of your uses of \placeholder in this change are similar to the uses where you changed to \placeholdernc. Did you make up your mind what looks better? Then, please be consistent.

I changed all added \placeholder{}s with \placeholdernc{}s to make you happy, but the surrounding Latex is inconsistent in its use of \placeholder v. \placeholdernc. We need to come up with some rules on which to use where, and do a global sweep to fix it.

Please don't blindly change \placeholder to \placeholdernc. The latter is a surgical tool for fixing cases of bad kerning due to italics corrections, and should be used sparingly only where there is actual bad kerning. Usually the italics correction is what we want; the bounding box for italicized text is wider due to the right overhang, and it so we want to create a little extra space.

I've found that \placeholdernc improves the presentation immediately before a period or a comma (where there is no higher text for the italics to get uncomfortably close to). So let's take that as rough guidance for now: use \placeholdernc before a teletype period or comma, where there would otherwise be an unsightly amount of horizontal space.

@zygoloid
Copy link
Member

zygoloid commented Aug 5, 2019

Looking through a few more examples, \placeholdernc before a left paren also seems more pleasant to my eye, but before a left angle bracket I prefer including the italic correction.

@burblebee
Copy link
Contributor Author

Most of your uses of \placeholder in this change are similar to the uses where you changed to \placeholdernc. Did you make up your mind what looks better? Then, please be consistent.

I changed all added \placeholder{}s with \placeholdernc{}s to make you happy, but the surrounding Latex is inconsistent in its use of \placeholder v. \placeholdernc. We need to come up with some rules on which to use where, and do a global sweep to fix it.

Leave this unresolved so we'll know to create an issue for it.

opened #3135

@burblebee
Copy link
Contributor Author

Looking through a few more examples, \placeholdernc before a left paren also seems more pleasant to my eye, but before a left angle bracket I prefer including the italic correction.

All the \placeholder{}s added in this motion occur before left parens, so it appears that the changes from \placeholder -> \placeholdernc in the Fixups are correct.

@zygoloid zygoloid merged commit e9e63a1 into master Aug 6, 2019
@jensmaurer jensmaurer deleted the motions-2019-07-lwg-30 branch December 15, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2019-07 LWG Motion 30] P1523R1 Views and Size Types
5 participants