New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P1523R1 Views and Size Types #3056
Conversation
I used \hfull\break to work around an Overfull issue - what should I have used? Also, shouldn't make-unsigned-like be introduced and explained somewhere? It first appears out of the blue in [range.prim.size]p1.3 (same for make-unsigned-like-t). |
They're introduced in P1522R1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of your uses of \placeholder in this change are similar to the uses where you changed to \placeholdernc. Did you make up your mind what looks better? Then, please be consistent.
I changed all added \placeholder{}s with \placeholdernc{}s to make you happy, but the surrounding Latex is inconsistent in its use of \placeholder v. \placeholdernc. We need to come up with some rules on which to use where, and do a global sweep to fix it. Leave this unresolved so we'll know to create an issue for it. |
Please don't blindly change I've found that |
Looking through a few more examples, |
opened #3135 |
All the \placeholder{}s added in this motion occur before left parens, so it appears that the changes from \placeholder -> \placeholdernc in the Fixups are correct. |
eaa446c
to
73a2047
Compare
Fixes #3034.