Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid example in [diff.cpp11.lex] #306

Closed
jwakely opened this issue Jun 2, 2014 · 1 comment
Closed

Invalid example in [diff.cpp11.lex] #306

jwakely opened this issue Jun 2, 2014 · 1 comment

Comments

@jwakely
Copy link
Member

jwakely commented Jun 2, 2014

[diff.cpp11.lex] has this example:

#define M(x, ...) __VA_ARGS__
int x[2] = { M(1’2,3’4) };
// int x[2] = {};      — C ++ 2011
// int x[2] = { 3’4 }; — this International Standard

However, that isn't valid C++11, [cpp.replace]/4 says that for a variadic macro:

there shall be more arguments in the invocation than there are parameters in the macro definition (excluding the ...).
@FilipRoseen-refp
Copy link

I propose this minor rewrite of the example, it still maintains the same intent but is actually valid C++11 and C++14:

#define M(x, ...) __VA_ARGS__
int a[] = { M(1'2, 3'4, 5) };

// int a[] = { 5 };       — C++ 2011
// int a[] = { 3'4, 5 };  — this International Standard

jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 12, 2016
@jensmaurer
[diff.cpp11.lex] fix example for digit separators
b18bea0 
Fixes cplusplus#306.
@jensmaurer jensmaurer mentioned this issue Nov 12, 2016
Merged
tkoeppe pushed a commit that referenced this issue Nov 12, 2016
@jensmaurer @tkoeppe
[diff.cpp11.lex] Fix example for digit separators (#1004)
e974f19 
Fixes #306.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwakely @FilipRoseen-refp