Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coroutine.handle.resumption] "an instance of std::thread" is not an execution agent #3067

Open
jwakely opened this issue Jul 23, 2019 · 3 comments
Open

[coroutine.handle.resumption] "an instance of std::thread" is not an execution agent #3067

jwakely opened this issue Jul 23, 2019 · 3 comments
Labels
lwg Issue must be reviewed by LWG.

Comments

@jwakely
Copy link
Member

jwakely commented Jul 23, 2019 •
edited

The wording (pre-Cologne) says:

has implementation-defined behavior unless each execution agent is either an instance of std::thread or the thread that executes main.

This is a category error. An instance of std::thread is an object with class type, not an execution agent.

I think it wants to say "unless each execution agent is a thread started by std::thread, or the thread that executes main."
@jwakely
Copy link
Member Author

jwakely commented Jul 24, 2019

PR #3072 touches this wording, so fixing it should wait for that to land.

@jensmaurer
Copy link
Member

#3072 has landed.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 3, 2019
@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 21, 2019
@jensmaurer
Copy link
Member

jensmaurer commented Oct 21, 2019 •
edited

Editorial meeting: Go with Jonathan's suggestion. Retain "either ... or".

Existing wording is actually wrong, so have SG1 / LWG oversight here. "started by" is probably right (given detached threads), but that's a normative change.

@jensmaurer jensmaurer added the lwg Issue must be reviewed by LWG. label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lwg Issue must be reviewed by LWG.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwakely @jensmaurer