New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[algorithms] Split list items conventionally #3073
Conversation
FWIW, most opinions are that the "or"s (which I added) are incorrect and should be changed to "and"s. I'm not an editor - so I can't click "merge" in any case - but I'd prefer to see a PR with the opposite change. |
Me too. I noticed a motion PR using "or" and checked if it should be "and" instead. The majority's preference would have to wait until after its merge. |
@zygoloid, this probably needs your opinion. |
Maybe take neither option, and replace ", and" with a semicolon and no conjunction. |
Editorial meeting: [alg.all.of] p1 construction is no good. The "or" is definitely wrong (who gets to choose?); some sympathy to avoid the "and". Maybe have a period for "returns", semicolon in the other cases. No "or" or "and". |
I'm currently preparing this PR to apply those changes. What do you recommend doing in light of P1718? |
00103e2
to
fdef2d7
Compare
Thank you.
What do you mean? The paper will go forward as-is. The editors likely need to do the merge by hand. So be it. |
IIRC, @mclow provides you the sources to ease the merge. With this PR, you'd definitely need to merge by hand. |
source/algorithms.tex
Outdated
|
||
\pnum | ||
\returns | ||
\tcode{X\{x, y\}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
49e928d
to
36c09e0
Compare
Questions:
|
Limiting the changes to what was approved in the editorial meeting and strictly grammar and whitespace fixes. Expect me bring up the other changes when this is merged. |
e3572ad
to
0429dac
Compare
All other Returns: elements with the same form use "or".