Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[algorithms] Split list items conventionally #3073

Merged
merged 3 commits into from Jan 14, 2020

Conversation

JohelEGP
Copy link
Contributor

All other Returns: elements with the same form use "or".

@CaseyCarter
Copy link
Contributor

FWIW, most opinions are that the "or"s (which I added) are incorrect and should be changed to "and"s. I'm not an editor - so I can't click "merge" in any case - but I'd prefer to see a PR with the opposite change.

@JohelEGP
Copy link
Contributor Author

Me too. I noticed a motion PR using "or" and checked if it should be "and" instead. The majority's preference would have to wait until after its merge.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Jul 24, 2019
@jensmaurer
Copy link
Member

@zygoloid, this probably needs your opinion.

@zygoloid
Copy link
Member

zygoloid commented Aug 7, 2019

Maybe take neither option, and replace ", and" with a semicolon and no conjunction.

@jensmaurer
Copy link
Member

Editorial meeting: [alg.all.of] p1 construction is no good. The "or" is definitely wrong (who gets to choose?); some sympathy to avoid the "and". Maybe have a period for "returns", semicolon in the other cases. No "or" or "and".

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 21, 2019
@JohelEGP
Copy link
Contributor Author

JohelEGP commented Oct 22, 2019

I'm currently preparing this PR to apply those changes. What do you recommend doing in light of P1718?

@jensmaurer
Copy link
Member

I'm currently preparing this PR to apply those changes.

Thank you.

What do you recommend doing in light of P1718?

What do you mean? The paper will go forward as-is. The editors likely need to do the merge by hand. So be it.

@JohelEGP
Copy link
Contributor Author

IIRC, @mclow provides you the sources to ease the merge. With this PR, you'd definitely need to merge by hand.

@JohelEGP JohelEGP changed the title [alg.find.end] Separate Returns: items with "or" for consistency [algorithms] Split list items conventionally Oct 22, 2019

\pnum
\returns
\tcode{X\{x, y\}},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the missing braces in the code.
Before:
1571765957
After:
1571765920

@JohelEGP
Copy link
Contributor Author

Questions:

  • Should [alg.adjacent.find]'s Complexity: be made into a list with one item per "overloads", like other lists touched in this PR, like in [alg.equal]'s Complexity:? Maybe the converse?
  • Should [mismatch]'s 3 Let's be joined into one Let: with 3 items like in [alg.find.end], [alg.equal], [alg.transform]? How about [alg.copy]p14, [alg.move]p11, [alg.remove]p8-9 (there's inconsistency in the ammount of \pnums), [alg.unique] p1 and p6? Maybe the converse?

@JohelEGP
Copy link
Contributor Author

Limiting the changes to what was approved in the editorial meeting and strictly grammar and whitespace fixes. Expect me bring up the other changes when this is merged.

@zygoloid zygoloid merged commit a4bf504 into cplusplus:master Jan 14, 2020
@JohelEGP JohelEGP deleted the alg.find.end branch January 14, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants