Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1814R0 Class template argument deduction for alias template #3075

Merged
merged 5 commits into from Aug 3, 2019
Merged

P1814R0 Class template argument deduction for alias template #3075

merged 5 commits into from Aug 3, 2019

Conversation

jensmaurer
Copy link
Member

  • fixed one f' / f1' vs. f1' / f2' confusion in the example

Fixes #3001.

@burblebee burblebee self-assigned this Aug 1, 2019
burblebee
burblebee requested changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edits were (mostly) fine, but the wording is problematic - I really hope we can fix this editorially before merging this paper!

source/declarations.tex Outdated Show resolved Hide resolved
source/overloading.tex Outdated Show resolved Hide resolved
source/overloading.tex Outdated Show resolved Hide resolved
source/overloading.tex Outdated Show resolved Hide resolved
source/overloading.tex Show resolved Hide resolved
source/overloading.tex Outdated Show resolved Hide resolved
source/overloading.tex Outdated Show resolved Hide resolved
source/overloading.tex Outdated Show resolved Hide resolved
source/overloading.tex Outdated Show resolved Hide resolved
source/overloading.tex Outdated Show resolved Hide resolved
burblebee
burblebee approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not happy with wording (see unresolved comments), but edits are correct.

@zygoloid
[over.match.class.deduct] Fix failure to handle the case where a
6e84545 
deducible alias template's defining-type-id contains a
nested-name-specifier (or 'typename' or 'template' keywords).
@zygoloid
[over.match.class.deduct] Switch from imperative to passive, and clarify
7226ced 
what happens if the various 'if' conditions are not met.
@zygoloid
[over.match.class.deduct] Put all bullets describing the properties of
6552c03 
f' at the same depth, and guard them all by the condition that we're
actually adding an f' to the set of guides.
@zygoloid zygoloid merged commit 1bac4eb into master Aug 3, 2019
@jensmaurer jensmaurer deleted the motions-2019-07-cwg-21 branch December 15, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid left review comments

@burblebee burblebee burblebee approved these changes

Assignees

@burblebee burblebee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2019-07 CWG Motion 21] P1814R0 Wording for Class Template Argument Deduction for Alias Template
3 participants
@jensmaurer @zygoloid @burblebee