Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1004R2 Making std::vector constexpr #3078

Merged
merged 1 commit into from Aug 6, 2019
Merged

P1004R2 Making std::vector constexpr #3078

merged 1 commit into from Aug 6, 2019

Conversation

burblebee
Copy link
Contributor

[vector.special] Could not apply the change to this section;
the section no longer exists, and its itemdecl for swap has been removed.

Fixes #3030.

@jwakely
Copy link
Member

jwakely commented Jul 25, 2019

[vector.special] was removed by 8738c6b because [tab:container.req] specifies swap(a, b) for all containers, so re-specifying it for each container was redundant.

@jwakely
Copy link
Member

jwakely commented Jul 25, 2019

P1614R2 (#3016) adds new non-member functions which should also be marked constexpr.

@burblebee
Copy link
Contributor Author

P1614R2 (#3016) adds new non-member functions which should also be marked constexpr.

@jwakely How should we deal with that?

@jwakely
Copy link
Member

jwakely commented Jul 30, 2019

I suggest adding a commit to #3098 to add constexpr to the relevant functions (that pull request didn't exist when I made the earlier comment, that's why I commented here).

@zygoloid
P1004R2 Making std::vector constexpr
5a0eaa9 
[vector.special] Could not apply the change to this section;
the section no longer exists, and its itemdecl for swap has been removed.

std::vector operators <, >, <=, >=, != have been removed. constexpr was
added to operator<=> instead to preserve the intent.

Fixes #3030.
@zygoloid zygoloid merged commit 3db86f6 into master Aug 6, 2019
@jensmaurer jensmaurer deleted the motions-2019-07-lwg-26 branch December 15, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2019-07 LWG Motion 26] P1004R2 Making std::vector constexpr
3 participants
@burblebee @jwakely @zygoloid