Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1703R1 Recognizing header unit imports requires full preprocessing #3081

Merged
merged 2 commits into from Aug 3, 2019
Merged

P1703R1 Recognizing header unit imports requires full preprocessing #3081

merged 2 commits into from Aug 3, 2019

Conversation

jensmaurer
Copy link
Member

Fixes #3003.

@burblebee burblebee self-assigned this Aug 1, 2019
burblebee
burblebee requested changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to inline comments, there's a remaining reference to cpp.module in modules.tex line 481 - should be changed to cpp.import.

source/lex.tex Outdated Show resolved Hide resolved
source/preprocessor.tex Show resolved Hide resolved
source/preprocessor.tex Outdated Show resolved Hide resolved
burblebee
burblebee approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - see 2 suggested changes inline.

source/basic.tex Outdated Show resolved Hide resolved
source/preprocessor.tex Show resolved Hide resolved
@zygoloid zygoloid merged commit f7a9b2b into master Aug 3, 2019
@jensmaurer jensmaurer deleted the motions-2019-07-cwg-24 branch December 15, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burblebee burblebee burblebee approved these changes

Assignees

@burblebee burblebee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2019-07 CWG Motion 24] P1703R1 Recognizing Header Unit Imports Requires Full Preprocessing
3 participants
@jensmaurer @burblebee @zygoloid