Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1135R6 The C++20 synchronization library #3093

Merged
merged 7 commits into from Aug 5, 2019
Merged

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Jul 27, 2019

  • [atomics.wait] Make singular.

Fixes #3013.

@jensmaurer
Copy link
Member Author

jensmaurer commented Jul 28, 2019

Note for P1643R1 Add wait/notify to atomic_ref: The wording keeps talking about *ptr, but ptr is never introduced or explained. The wording as-is thus makes little sense.
@CaseyCarter has explained that ptr is an exposition-only member of atomic_ref<T>, so my concern is moot.

Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review summary for 1st paper P1135R6: wording is bad, but edits are bad too.

source/atomics.tex Outdated Show resolved Hide resolved
source/atomics.tex Outdated Show resolved Hide resolved
source/atomics.tex Show resolved Hide resolved
source/atomics.tex Show resolved Hide resolved
source/atomics.tex Show resolved Hide resolved
source/threads.tex Show resolved Hide resolved
source/threads.tex Outdated Show resolved Hide resolved
source/threads.tex Outdated Show resolved Hide resolved
source/threads.tex Outdated Show resolved Hide resolved
source/threads.tex Outdated Show resolved Hide resolved
@burblebee
Copy link
Contributor

sorry i can't finish this review right now - will try and find some time later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2019-07 LWG Motion 9] P1135R6 The C++20 Synchronization Library
3 participants