[temp.deduct] editorial changes to clarify substitution #3095
Conversation
zygoloid
added
the
changes requested
An initial reading of [temp.deduct] may be confusing given the repeated and sometimes ambiguous use of the term substitution. This revision should make that clearer.
|
@zygoloid Mr. Smith, I was just wondering if the rewording that I did in response your helpful comments satisfied you. Please let me know if/how I can do further work on this. Thanks again for the feedback on this rewording! |
jensmaurer
removed
the
changes requested
| not been deduced and its corresponding template parameter has a | ||
| default argument, the template argument is determined by substituting | ||
| the template arguments determined for preceding template parameters | ||
| into the default argument. If the substitution results in an invalid type, |
There was a problem hiding this comment.
We're trying to use semantic line breaks in any text newly entering the standard. https://sembr.org/
That means (at the very least) that every sentence starts on a new line. Please adjust accordingly.
There was a problem hiding this comment.
Yeah this paragraph's diff would have been a lot easier to review if there was a line break after the first sentence, because the rest of the paragraph is unchanged. Your rejustification is unhelpful, it makes it look like the entire paragraph has changed.
| those constraints are checked for satisfaction\iref{temp.constr.constr}. | ||
| If the constraints are not satisfied, type deduction fails. | ||
| The template argument values determined above by template argument deduction | ||
| or default template arguments are substituted for their corresponding template |
There was a problem hiding this comment.
I dislike "determined above by ... or default template arguments". We do not determined them "by default template arguments". We obtain them, which is what the original text says.
Maybe just insert "obtained from" before "default template arguments", or maybe:
The template argument values found by template argument deduction or obtained from default template arguments are substituted ...
Also, "template argument values" ? These are not necessarily values.
Edit: I see that [temp.deduct] p1 refers to these as values. Huh.
|
@hawkinsw: Could you please rebase and switch to semantic line breaks as requested? I'm not entirely sure yet what we'll do with this suggestion; I'm tempted to get CWG to take a look at it (or at least have some CWG members review it). |
tkoeppe
added
changes requested
An initial reading of [temp.deduct] may be confusing given
the repeated and sometimes ambiguous use of the term substitution.
This revision should make that clearer.