Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1614R2 Adding <=> to the Library #3098

Merged
merged 3 commits into from Aug 5, 2019
Merged

P1614R2 Adding <=> to the Library #3098

merged 3 commits into from Aug 5, 2019

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Jul 29, 2019 •
edited

Fixes #3016.

@jwakely jwakely mentioned this pull request Jul 30, 2019
Merged
@jensmaurer jensmaurer force-pushed the motions-2019-07-lwg-12 branch 3 times, most recently from 570f81d to d5be236 Compare July 30, 2019 14:03
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/support.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/support.tex Outdated Show resolved Hide resolved
@brevzin
Copy link
Contributor

brevzin commented Jul 30, 2019 •
edited

Given #3099, should this just preemptively replace ThreeWayComparable{,With} with three_way_comparable{,_with}, or is that intended to be done separately?

JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/support.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/support.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/support.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/support.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Jul 30, 2019
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
@jensmaurer
Copy link
Member Author

@brevzin, we'll do the renaming at the end; see #3015.

@zygoloid
Copy link
Member

zygoloid commented Aug 5, 2019

@jensmaurer This is the next motion to merge, but I'm done for the night. I'll add the missing definition of ThreeWayComparableWith and finish my review tomorrow (maybe 10am Pacific) if you don't get there first. Note that I've already rebased this on master, so you'll need to deal with that when pulling.

@jensmaurer
Copy link
Member Author

@zygoloid Ah, the joys of timezones. I've added the missing concept definition. "git pull --rebase" did the trick for me.

jensmaurer and others added 3 commits August 5, 2019 16:42
@jensmaurer @zygoloid
P1614R2 Adding <=> to the library
30e601f 
 - Remove mention of 'spaceship' in subclause headings.
 - For the concept partially-ordered-with, use "model", not "satisfied".
 - Rework [cmp.object] to align with other library descriptions.
 - Add header synopsis entry for struct has_strong_structural_equality
and add _v variable template.
 - Fix note in [container.requirements.general] p14.
 - Other comparisons for chrono::time_zone and chrono::link are not
constexpr; existing text was misquoted. Do not make <=> constexpr.
 - Fix merge conflicts with P0784R7, which adds 'constexpr' to allocator
   operator!= (function deleted by this paper).
@jensmaurer @zygoloid
Apply P1452R2 On the non-uniform semantics of return-type-requirements
d243672 
to newly-introduced return type requirements.
@zygoloid
Rename _s to -s in placeholder names per editorial guidelines.
90f6479
@zygoloid zygoloid merged commit 27cad22 into master Aug 5, 2019
@jensmaurer jensmaurer deleted the motions-2019-07-lwg-12 branch December 15, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid left review comments

@JohelEGP JohelEGP JohelEGP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2019-07 LWG Motion 12] P1614R2 The Mothership has Landed
4 participants
@jensmaurer @brevzin @zygoloid @JohelEGP