P1754R1 Rename concepts to standard_case for C++20 #3099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 26, 2019 03:03
Fixed whitespace issues seen during review. Fixed additional inconsistencies in the Latex used for concept names. [concept.strictweakorder] Fix \indexlibrary for strict_weak_order. [ranges] Change ranges::view to ranges::views. Fixes #3015.
jwakely
requested changes
Jul 30, 2019
JohelEGP
suggested changes
Jul 30, 2019
CaseyCarter
reviewed
Jul 31, 2019
CaseyCarter
reviewed
Jul 31, 2019
jensmaurer
changed the title
JohelEGP
suggested changes
Jul 31, 2019
added 2 commits
July 31, 2019 12:41
… naming scheme.
* \placeholdernc{Advanceable} => \placeholdernc{advanceable}
* \placeholdernc{same-impl} => \placeholdernc{same-as-impl}
* \placeholdernc{Decrementable} => \placeholdernc{decrementable}
…tions for consistency. * concept.convertibleto => concept.convertible * concept.derivedfrom => concept.derived * concept.stricttotallyordered => concept.totallyordered
CaseyCarter
approved these changes
Jul 31, 2019
|
Thanks again for all the work on this, @burblebee, I really should have prepared this PR myself. |
|
@jwakely you marked this "changes requested" - I addressed all of your concerns afaik. Might you please have a quick look to make that go away? I don't like the red :) |
|
@zygoloid this motion is not complete - must be completed after all other motions are merged. |
Merged
jwakely
approved these changes
Aug 5, 2019
|
Rebasing this turned out to be more work than recreating the semi-mechanical renaming part, so I did that and kept all the other changes. This is superseded by #3149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.