Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1638R1 basic_istream_view::iterator should not be copyable #3107

Merged
merged 1 commit into from Aug 6, 2019
Merged

P1638R1 basic_istream_view::iterator should not be copyable #3107

merged 1 commit into from Aug 6, 2019

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Jul 30, 2019 •
edited

Fixes #3028.

I wanted this pull request to just contain the patch against P1035R7, but that apparently failed.

@jensmaurer jensmaurer changed the title Motions 2019 07 lwg 24 P1638R1 basic_istream_view::iterator should not be copyable Jul 30, 2019
@JohelEGP
Copy link
Contributor

That's because you want to merge into master, which doesn't have P1035R7.

JohelEGP
JohelEGP suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

& and && hug the type.

source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
CaseyCarter
CaseyCarter reviewed Jul 31, 2019
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
@burblebee
Copy link
Contributor

@CaseyCarter can you approve this?

CaseyCarter
CaseyCarter approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes this PR applies from P1638R1 - the last three commits - are correct, but the PR also includes P1035 changes and should not be merged without rebasing onto the result of merging #3106.

@burblebee, Could we label this rebase-required to ensure no one merges it without performing that rebase?

@burblebee
Copy link
Contributor

The changes this PR applies from P1638R1 - the last three commits - are correct, but the PR also includes P1035 changes and should not be merged without rebasing onto the result of merging #3106.

@burblebee, Could we label this rebase-required to ensure no one merges it without performing that rebase?

@CaseyCarter, @zygoloid will do this when he merges this motion.

@JohelEGP
Copy link
Contributor

JohelEGP commented Aug 6, 2019 •
edited

Or do as @zygoloid did with Text Formatting and its various modifying papers, and add it to the same PR.

@zygoloid zygoloid merged commit 69fe79d into master Aug 6, 2019
@jensmaurer jensmaurer deleted the motions-2019-07-lwg-24 branch December 15, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP JohelEGP requested changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2019-07 LWG Motion 24] P1638R1 basic_istream_view::iterator should not be copyable
5 participants
@jensmaurer @JohelEGP @burblebee @CaseyCarter @zygoloid