P0408R7 Efficient Access to basic_stringbuf ’s Buffer #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
changed the title
jensmaurer
reviewed
Jul 31, 2019
jensmaurer
reviewed
Jul 31, 2019
jensmaurer
reviewed
Jul 31, 2019
|
@jensmaurer @jwakely Can one of you re-review and approve please? |
|
There's a button next to the name under "Reviewers" to request a re-review. |
zygoloid
force-pushed
the
motions-2019-07-lwg-14
branch
2 times, most recently
from
d42d29c
to
64c34ca
Compare
added 3 commits
August 5, 2019 17:21
Fixed punctuation in \effects clauses.
[stringbuf] Omitted duplicate constructor in synopsis.
[stringbuf.cons] Added missing const on string parameter in itemdecl of
basic_stringbuf to match declaration in synopsis.
Fixes #3018.
…cy and to avoid confusion with "str" methods.
"str()" should be "str"; we're talking about all str member functions here. Add comma after "For efficiency reasons". "i.e." -> "e.g." since we're describing an example case.
zygoloid
force-pushed
the
motions-2019-07-lwg-14
branch
from
64c34ca
to
26f7cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3018.
Notes:
"Add a conditional noexcept specification to swap with see below:"
but "see below" is not used in the wording for this swap member.