New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to [depr.volatile] #3123
Conversation
source/future.tex
Outdated
\begin{example} | ||
\begin{codeblock} | ||
volatile int velociraptor; | ||
++velociraptor; // deprecated: is this a single memory operation, two, or a six-foot turkey? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tone of this comment is too flippant, and doesn't really work as a rationale for deprecation (since the same question applies for all non-deprecated volatile operations, which are all just as implementation-defined as each other).
Just saying "// deprecated" seems fine (here and below). We don't need to justify why things are deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a very Cultured reference, but I can drop it if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote from https://isocpp.org/std/standing-documents/sd-4-wg21-practices-and-procedures#code-of-conduct:
"Avoid metaphors, irony & be aware that jokes and humor may not translate"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped the reference, but I don't think we want to drop the explanations. I was explicitly asked for them in CWG.
592a83f
to
083832b
Compare
@zygoloid @jensmaurer what's the status of this change? I don't think anything remains to be changed. |
As promised in cplusplus#2999.
Co-Authored-By: Casey Carter <Casey@Carter.net>
Co-Authored-By: Casey Carter <Casey@Carter.net>
Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
083832b
to
eca059c
Compare
@zygoloid, where are we here? |
As promised in #2999.