Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to [depr.volatile] #3123

Merged
merged 18 commits into from Mar 13, 2020

Conversation

jfbastien
Copy link
Contributor

As promised in #2999.

source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
\begin{example}
\begin{codeblock}
volatile int velociraptor;
++velociraptor; // deprecated: is this a single memory operation, two, or a six-foot turkey?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tone of this comment is too flippant, and doesn't really work as a rationale for deprecation (since the same question applies for all non-deprecated volatile operations, which are all just as implementation-defined as each other).

Just saying "// deprecated" seems fine (here and below). We don't need to justify why things are deprecated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a very Cultured reference, but I can drop it if you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote from https://isocpp.org/std/standing-documents/sd-4-wg21-practices-and-procedures#code-of-conduct:
"Avoid metaphors, irony & be aware that jokes and humor may not translate"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped the reference, but I don't think we want to drop the explanations. I was explicitly asked for them in CWG.

@zygoloid zygoloid added the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 6, 2019
source/future.tex Outdated Show resolved Hide resolved
source/future.tex Outdated Show resolved Hide resolved
@jfbastien
Copy link
Contributor Author

@zygoloid @jensmaurer what's the status of this change? I don't think anything remains to be changed.

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 18, 2020
jfbastien and others added 14 commits March 4, 2020 09:53
Co-Authored-By: Casey Carter <Casey@Carter.net>
Co-Authored-By: Casey Carter <Casey@Carter.net>
Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
@jensmaurer
Copy link
Member

@zygoloid, where are we here?

@zygoloid zygoloid merged commit b6d9e27 into cplusplus:master Mar 13, 2020
@jfbastien jfbastien deleted the depr.volatile-examples branch March 24, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants