Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with the wording for P1135R6 added in #3093 #3133

Open
burblebee opened this issue Aug 6, 2019 · 1 comment
Open

Problems with the wording for P1135R6 added in #3093 #3133

burblebee opened this issue Aug 6, 2019 · 1 comment
Labels
lwg Issue must be reviewed by LWG.

Comments

@burblebee
Copy link
Contributor

  • The wording added to [thread.barrier.class]p1 says "the completion step is run on one of the threads that arrived at the barrier during the phase". What are we actually saying here?
  • The wording added to [thread.barrier.class]p1 says "The expected count is decremented ..." - what's the "expected count"?
@burblebee burblebee added the lwg Issue must be reviewed by LWG. label Aug 6, 2019
@jwakely
Copy link
Member

jwakely commented Aug 8, 2019

I think the preamble should define expected count and initial expected count, the latter being what the current wording refers to as "what was specified by the expected argument to the constructor" (which should say "parameter" not "argument", or "argument that initializes the expected parameter", but should probably just be "the value of the constructor's expected parameter").

  • The wording added to [thread.barrier.class]p1 says "the completion step is run on one of the threads that arrived at the barrier during the phase". What are we actually saying here?

That the thread that runs the phase completion step is not necessarily the last one to arrive at the barrier (except for the special case of the default completion function, which has a no-op completion function, and so I'm not sure whether it's observable which thread it runs on and so I don't know why we need to call out that special case).

Instead of " For the specialization with the default value of the CompletionFunction template parameter" could we just say "for the specialization barrier<>"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lwg Issue must be reviewed by LWG.
Projects
None yet
Development

No branches or pull requests

2 participants