Lost changes to P1754R1 (LWG Motion 11) #3153
Conversation
|
The build is timing out with "Timeout waiting for network availability." |
jensmaurer
added
the
needs rebase
|
Please rebase and fix the conflicts, then force-push. |
|
I think this is obsolete now, @burblebee? |
|
@tkoeppe, no these changes were absolutely needed. I didn't realize they hadn't been applied yet. |
|
Aha, thank you, sorry about that! Could you please open a regular pull request for those changes then? (Or indeed reopen and update this one?) Thanks! |
Is this not a regular PR? Yes, will update and rebase after the current motions are applied ( I suspect many of these changes have been found and fixed already). |
|
Sorry, yes, this is of course a regular PR, I failed to say that I was implicitly thinking "from a branch on your own fork", as opposed to adding PR branches to this repo. But let's leave this as is now, once it's rebased and dealt with, we'll delete the branch. Thanks! |
burblebee
force-pushed
the
motions-2019-07-lwg-11-rs
branch
from
9f71bcc
to
23906d9
Compare
jensmaurer
removed
the
needs rebase
burblebee
force-pushed
the
motions-2019-07-lwg-11-rs
branch
from
23906d9
to
38f97d8
Compare
burblebee
force-pushed
the
motions-2019-07-lwg-11-rs
branch
from
38f97d8
to
c2ffe2c
Compare
These fixes from branch motions-2019-07-lwg-11 were lost in the new branch motions-2019-07-lwg-11-rs. The 2nd commit in this PR encodes additional but unconventional uses of concept names with \libconcept, but more work may still be needed - see related inline comments in PR #3149.
Update 2/25/21: Most of the changes in the original patch had already been fixed in master since this PR was created. The rebased branch has been updated to include the few changes that remain in master.