Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread.jthread.class] suggests the thread joins itself #3157

Closed
jwakely opened this issue Aug 8, 2019 · 1 comment · Fixed by #3162
Closed

[thread.jthread.class] suggests the thread joins itself #3157

jwakely opened this issue Aug 8, 2019 · 1 comment · Fixed by #3162
Assignees

Comments

@jwakely
Copy link
Member

jwakely commented Aug 8, 2019

As I said at #3072 (review) I think this wording is unclear and inaccurate:

The functionality is the same as for class thread (32.4.2) with the additional ability to request that the thread stops and then joins the started thread.

The threads referred to as "the thread" and "the started thread" are actually the same thread, so this says "the ability to request that the thread stops and then joins itself" which is not what the class does.

I suggest:

The functionality is the same as for class thread (32.4.2) with the additional abilities to provide a stop_token (32.3) to the new thread of execution, make stop requests, and automatically join.

@jensmaurer jensmaurer self-assigned this Aug 8, 2019
@jensmaurer
Copy link
Member

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants