Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[index] Add index of concept names. #3159

Merged
merged 1 commit into from Sep 30, 2019
Merged

Conversation

jensmaurer
Copy link
Member

Fixes #2959.

@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Aug 20, 2019
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Aug 20, 2019
@jensmaurer jensmaurer added decision-required A decision of the editorial group (or the Project Editor) is required. big An issue causing a large set of changes, scattered across most of the text. labels Sep 23, 2019
@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 25, 2019

I haven't looked at the output, but as long as it works with latexmk and looks as expected, the approach looks reasonable. Feel free to merge!

@jensmaurer
Copy link
Member Author

Sample index page:

index

Since this is replacing \placeholder/nc with semantic macros (without the "nc"), there are some slight whitespace changes in the main text.

Before:
before2

After:
after2

If this is undesirable, I fear I have to introduce "nc" variants of the macros. Please advise.

@jensmaurer
Copy link
Member Author

(Uh, same-as shouldn't be italics in the "after" picture. Will fix right now.)

@jensmaurer
Copy link
Member Author

Editorial teleconference: introduce \libconceptx to fix \cname use in ranges.tex. Otherwise good to merge.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Sep 30, 2019
@jwakely
Copy link
Member

jwakely commented Oct 10, 2019

This seems to have borked the bookmarks in the PDF:
Screenshot_20191010_102740

@jensmaurer
Copy link
Member Author

Rats.

@jensmaurer
Copy link
Member Author

Is there any way to do different things in an \rSec vs. outside?

@jensmaurer
Copy link
Member Author

Repaired by #3286.

@Eelis
Copy link
Contributor

Eelis commented Aug 26, 2020

For the same_as example, the library concept index now also has an entry for same-as-impl, which is an exposition-only name only used in the implementation of same_as.
Was this intentional? :) Looks a bit weird, because why would a reader ever look up same-as-impl in the index?

@jensmaurer
Copy link
Member Author

Well, in general we also add exposition-only concepts to the index, because they might be used far away from their definition. That's certainly not the case for same-as-impl, but it feels slightly inconsistent to decide this on a case-by-case basis.

@Eelis
Copy link
Contributor

Eelis commented Aug 26, 2020

Ah fair enough, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big An issue causing a large set of changes, scattered across most of the text.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An index of library concepts would be extremely useful
4 participants