New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[version.syn] Add synopsis for <version> header. #3163
Conversation
@zygoloid , did you have something like this in mind? |
Alternately, we could eliminate the table and make the definitions explicit in the synopsis: #define __cpp_lib_concepts 201806L // Also in: <concepts> It seems silly to have a synopsis with simply |
I like @CaseyCarter's suggestion. Let's try treating these like any other macro the library provides. |
If desired, I can add section cross-references after each mention of a header. Please advise. |
IMO the cross-references would look cluttered (especially if given on every mention of a header, not just the first mention). |
I like this. Has anyone already done a pass over a before and after document to check that the macros and versions all match? This seems like an easy change for a typo to slip into unnoticed. |
I have just performed such a pass; it's all good. |
30c6fc1
to
3bca574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This replaces the table of feature-test macros for the library.
Fixes #3147.