[locale.numpunct,locale.moneypunct] Canonicalize local grammar presen… #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good to me, but if you're changing this anyway how about addressing two pre-existing issues.
Finally, does it matter that sign and units are defined as part of the integer grammar, but used in the floatval one? |
|
Fixed the two issues mentioned in the bullets. Leaving the "sign" and "units" issue as-is; the two grammar snippets are right next to each other. |
jwakely
approved these changes
Aug 15, 2019
|
Leaving for @zygoloid to apply. |
zygoloid
added
the
needs rebase
|
After rebasing, could you attach an image of the "after" presentation? Thanks! |
…tation. In [locale.numpunct], rename the 'integer' non-terminal to 'intval', consistent with 'floatval'. Also remove the superfluous 'plusminus' non-terminal.
jensmaurer
removed
the
needs rebase
|
Rebased. Here are the pictures: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tation.
Fixes #3100.