Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\placeholer{} adds a space #319

Closed
burblebee opened this issue Jun 16, 2014 · 5 comments
Closed

\placeholer{} adds a space #319

burblebee opened this issue Jun 16, 2014 · 5 comments
Assignees
@burblebee

Comments

@burblebee
Copy link
Contributor

In e-mail from Richard:
Dawn: - \placeholder{} appends a space after its contents, which prevents it from being used inside other macros. For example, "\tcode{is_reference<\placeholder{R}>::value}" turns into "is_reference::value". How to fix/workaround? Should I remove space from macro and add extra space after all uses of \placeholder{} in spec where a space is desired?

Richard: Yes, please fix the macro. It shouldn't be adding a trailing space.
@burblebee burblebee self-assigned this Jun 16, 2014
@burblebee
Copy link
Contributor Author

Once fixed, LWG2106 should be changed to as follows:
"Let \placeholder{R} be \tcode{iterator_traits::reference}.
If \tcode{is_reference<\placeholder{R}>::value} is \tcode{true},
the template specialization \tcode{move_iterator} shall
define the nested type named \tcode{reference} as a synonym for
\tcode{remove_reference<\placeholder{R}>::type&&},
otherwise as a synonym for \placeholder{R}."

@zygoloid zygoloid mentioned this issue Dec 9, 2015
Merged
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 11, 2015

@burblebee, @zygoloid: Do you want to go ahead with changing }\placeholder{X}\tcode{ into \placeholder{X}? I think that's the right course of action, though Issue #326 discusses an alternative.

I can definitely make a PR that changes is_reference<R>::value in the motivating example.

@tkoeppe tkoeppe mentioned this issue Dec 11, 2015
Merged
@burblebee
Copy link
Contributor Author

On Fri, Dec 11, 2015 at 02:21:50AM -0800, Thomas Köppe wrote:

@burblebee, @zygoloid: Do you want to go ahead with changing }\placeholder{X}\tcode{ into \placeholder{X}? I think that's the right course of action, though Issue #326 discusses an alternative.

Fine with me. Thanks for doing this!

@burblebee
Copy link
Contributor Author

Can we close this now? The fix to the \placeholder macro was merged was it not?

@burblebee
Copy link
Contributor Author

burblebee commented Jul 7, 2016 •
edited

Fixed in the following master commits.

Fix for placeholder macro:

Uses applied to text:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burblebee burblebee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkoeppe @burblebee