[temp.param] Remove unused class template from example. #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Aug 24, 2019
jensmaurer
reviewed
Aug 24, 2019
jensmaurer
requested changes
Aug 24, 2019
jensmaurer
added
the
changes requested
rogerorr
changed the title
jensmaurer
approved these changes
Aug 24, 2019
|
Thanks. While the title of this pull request is now beautiful, you've actually queued up two commits, both of which lack a bit of splendor in their commit messages. Use "git log" to see it. Please do a "git rebase -i master", merge the two commits into one, and clean up the commit message. Then do a "git push -u rogerorr -f template-editorial" to force-push and replace everything that was upstream. (We can do that when we merge, but it's always easier if we have less work. Also, I can't merge without a second reviewer anyway, so we might forget eventually.) |
rogerorr
force-pushed
the
template-editorial
branch
from
8e0eb38
to
b3474dd
Compare
|
I have now rebased and force-pushed to get the right commit message and history. |
|
Jens, can the "change requested" label now be removed? |
jensmaurer
removed
the
changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.