[range.range] replace hyphens with dashes #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Sep 3, 2019
| @@ -839,7 +839,7 @@ | |||
| model \tcode{\placeholdernc{forwarding-range}}. \tcode{subrange} provides | |||
| non-member rvalue overloads of \tcode{begin} and \tcode{end} with the same | |||
| semantics as its member lvalue overloads, and \tcode{subrange}'s iterators | |||
| - since they are ``borrowed'' from some other range - | |||
| -- since they are ``borrowed'' from some other range -- | |||
There was a problem hiding this comment.
Is an em-dash (three ---) more appropriate for this? Ah, https://en.wikipedia.org/wiki/Dash says we wouldn't have spaces around it then.
There was a problem hiding this comment.
I also prefer spaced em dashes. If em dashes were consistently used in the document, I would have used em dahses.
Ah, https://en.wikipedia.org/wiki/Dash says we wouldn't have spaces around it then.
It's definitely OK to put spaces around em dashes — there are two styles (one with spaces and one without spaces).
Is an em-dash (three ---) more appropriate for this?
I just thought that the em dash just after the end of this sentence becomes interfering on the eye, if we use em dashes. But either works for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.