Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iterators] s/a == b/bool(a == b)/ and s/++a == ++b/bool(++a == ++b)/ #3209

Closed
wants to merge 1 commit into from
Closed

[iterators] s/a == b/bool(a == b)/ and s/++a == ++b/bool(++a == ++b)/ #3209

wants to merge 1 commit into from

Conversation

cjdb
Copy link
Contributor

@cjdb cjdb commented Sep 2, 2019

The boolean-expressions in [iterators] should be explicitly converted to
bool. This commit fixes a few strays that weren't boolified.

@cjdb cjdb changed the title s/a == b/bool(a == b)/ and s/++a == ++b/bool(++a == ++b)/ [iterators] s/a == b/bool(a == b)/ and s/++a == ++b/bool(++a == ++b)/ Sep 2, 2019
The boolean-expressions in [iterators] should be explicitly converted to
`bool`. This commit fixes a few strays that weren't boolified.
@jwakely
Copy link
Member

jwakely commented Sep 2, 2019

Is this correction already implied by a paper approved in Cologne? Otherwise, this is arguably not editorial and so would be better handled as an LWG issue.

@jensmaurer
Copy link
Member

References to prior art (papers, LWG issues) would be good. Otherwise, this sounds non-editorial.

@jensmaurer jensmaurer added the lwg Issue must be reviewed by LWG. label Sep 3, 2019
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jun 15, 2021
@tkoeppe tkoeppe closed this Jun 19, 2021
@tkoeppe tkoeppe deleted the branch cplusplus:master June 19, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lwg Issue must be reviewed by LWG. needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants