Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

true and false should be in \tcode{} when refering to bool value #321

Closed
burblebee opened this issue Jun 16, 2014 · 6 comments
Closed

true and false should be in \tcode{} when refering to bool value #321

burblebee opened this issue Jun 16, 2014 · 6 comments

Comments

@burblebee
Copy link
Contributor

In e-mail with Richard:
Dawn: In "or \tcode{alloca-tor_traits<allocator_type>::propagate_on_container_swap::value}
is true within the implementation of the corresponding container operation."
true should be in \tcode{} - ok to fix? Should make global fix in single commit for similar uses?

Richard: Yes, in all cases where it's referring to the 'bool' value 'true' or 'false' we should \tcode it (but not in cases like 5.9/5, where it's referring to the mathematical notion of truth nor in [temp.expl.spec]p5's "The same is true when [...]").
@burblebee burblebee self-assigned this Jun 16, 2014
@burblebee burblebee removed their assignment Nov 6, 2014
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 16, 2016

@burblebee, @zygoloid: Does #977 address this problem? Does it fix it?

@jlaire
Copy link

jlaire commented Nov 17, 2016 •
edited

In #977 I manually went through every match in git grep true and git grep false, so it should fix this but it's possible I missed some.

One of the less obvious cases I ran into is an integer value which is referred to as true (#978).

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 17, 2016

@jensmaurer: Care to check whether this issue is now resolved? :-)

@jensmaurer
Copy link
Member

$ grep -w false *.tex | grep -v tcode | grep -v "//" | grep -v static
still finds a few places that seem to be prose text and have "false" without \tcode in them.

jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 17, 2016
@jensmaurer
Use \tcode for true and false when discussing the result of a boolean…
cc4b9b2 
… operation.

Fixes cplusplus#321.
@jlaire
Copy link

jlaire commented Nov 17, 2016

After removing codeblocks, the results of that grep have these three:

  • Lines 1012-1013 in atomics.tex. I don't know if these should be have \tcode or not. Changing "the comparison is false" to "the result of the comparison is false" might be better in any case.
  • Line 4712 in locales.tex should be changed to say "0" or "zero" instead of "false".
  • Line 391 in preprocessor.tex (line 391), I don't know about this one.

I could create another PR, but if it's just a couple of changes it's probably easier for whoever can make the decisions to do it.

jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 17, 2016
@jensmaurer
Use \tcode for true and false when discussing the result of a boolean…
dd45a4f 
… operation.

Fixes cplusplus#321.
@jensmaurer
Copy link
Member

The remaining ones are borderline and best left alone in this general issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jlaire @tkoeppe @burblebee @jensmaurer