[concepts.arithmetic] fix notes that use undefined terms #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terms "signed integral types" and "unsigned integral types" are not defined in [basic.fundamental] The notes are trying to talk about signed/unsigned *integer* types. char and bool are not signed or unsigned *integer* types, but they certainly are *integral* types, and so they model one of signed_integral or unsigned_integral.
jensmaurer
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terms "signed integral types" and "unsigned integral types" are not
defined in [basic.fundamental] The notes are trying to talk about
signed/unsigned integer types.
charandboolare not signed orunsigned integer types, but they certainly are integral types, and
so they model one of
signed_integralorunsigned_integral.