Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lib] Use more abstract library indexing macros #3233

Merged
merged 6 commits into from Sep 30, 2019
Merged

[lib] Use more abstract library indexing macros #3233

merged 6 commits into from Sep 30, 2019

Conversation

jensmaurer
Copy link
Member

Partially addresses #3096.

@jensmaurer jensmaurer added the big An issue causing a large set of changes, scattered across most of the text. label Sep 24, 2019
@jensmaurer jensmaurer mentioned this pull request Sep 24, 2019
Closed
@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 25, 2019

Could you post a diffpdf screenshot? I think this is generally fine; I expect this causes no visible changes outside the index?

@jensmaurer
Copy link
Member Author

jensmaurer commented Sep 25, 2019 •
edited

"diffpdf" in "Appearance" mode shows no changes outside the index.

Sample diffpdf on index (in "Words" mode to remove fluff):

Screenshot_2019-09-25_18-12-42

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 25, 2019

Looks good, ship it!

zygoloid
zygoloid approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge after rebase.

@jensmaurer jensmaurer merged commit 5b721aa into cplusplus:master Sep 30, 2019
@jensmaurer jensmaurer deleted the c30 branch September 30, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

Assignees
No one assigned
Labels
big An issue causing a large set of changes, scattered across most of the text.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jensmaurer @tkoeppe @zygoloid