Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expr.prim.id] Fix immediate function id-expression requirement #3244

Merged
merged 1 commit into from Oct 6, 2019

Conversation

randomnetcat
Copy link
Contributor

Reason for being editorial: It is probably not the committee's intent to require all programs to use "an id-expression that denotes an immediate function".

@W-E-Brown
Copy link
Contributor

Without expressing any opinion re whether we want some such rewording, the proposed placement of "only" is suboptimal. To say that something "shall only appear ..." implies, for example, that it mustn't cook, clean, play, tap-dance, or snore -- the only thing it can do is appear.

If we decide that we do want a wording adjustment hereabouts, please consider injecting "only" in two places within this sentence: "... shall appear only as a subexpression of an immediate invocation or only in an immediate function context\iref{expr.const}." I'm less unhappy with that, but the sentence is too long, with too many qualifying phrases, to move "only" to the sentence end as I'd truly prefer.

It would be easiest if we had a short bullet list here: "... shall appear only: (bullet a) as a subexpression of an immediate invocation, or (bullet b) in an immediate function context\iref{expr.const}."

@@ -1270,7 +1270,7 @@
\pnum
An \grammarterm{id-expression}
that denotes an immediate function\iref{dcl.constexpr}
shall appear as a subexpression of an immediate invocation or
shall only appear as a subexpression of an immediate invocation or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Walter's suggestion of adding bullets and moving the only a little farther towards the end.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply Walter's suggestions.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Sep 25, 2019
Move possibilities into a list, and add "only" after "appear".

Reason for being editorial: not intent to require all programs
to use an "id-expression that denotes an immediate function",
and moving the possiblities into a list does not change the meaning.
@randomnetcat
Copy link
Contributor Author

Made the requested changes.

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Sep 25, 2019
@zygoloid zygoloid merged commit 37ca3fa into cplusplus:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants