Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mis-application of a bit of p1463r1 #3257

Closed
mclow opened this issue Oct 1, 2019 · 3 comments · Fixed by #3258
Closed

Mis-application of a bit of p1463r1 #3257

mclow opened this issue Oct 1, 2019 · 3 comments · Fixed by #3258
Assignees
@tkoeppe

Comments

@mclow
Copy link
Contributor

mclow commented Oct 1, 2019

http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1463r1.pdf

in [list.ops]/25, it adds the text "get_allocator() == x.get_allocator is true."
and removes the text "The behavior is undefined if get_allocator() != x.get_allocator"

When this paper was applied in commit 019baa9, the second text was removed (correctly), but the text that was added was "get_allocator() != x.get_allocator is true." ('!=' instead of '==')
@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 1, 2019

I can take this one. We also don't seem to have the edit , and, do you also want that (re-)instated?

@tkoeppe tkoeppe self-assigned this Oct 1, 2019
@mclow
Copy link
Contributor Author

mclow commented Oct 1, 2019

I like the , and, but if that doesn't match the rest of the standard, I can live w/o it.
On the other hand, [forwardlist.ops]/22 does have the "and".

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 1, 2019

I agree. It's awkward to start a sentence with a symbol. I'll reinstate both.

@tkoeppe tkoeppe mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[list.ops] Fix misapplication of P1463R1, "!=" should be "==". tkoeppe/draft
2 participants
@mclow @tkoeppe