Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All definitions should be indexed #329

Open
burblebee opened this issue Jun 18, 2014 · 6 comments
Open

All definitions should be indexed #329

burblebee opened this issue Jun 18, 2014 · 6 comments
Labels
big An issue causing a large set of changes, scattered across most of the text.

Comments

@burblebee
Copy link
Contributor

It was decided at the Rap. mtg that all definitions should be indexed, i.e., definitions which use \term{} should be fixed to use \defn{} or \defnx{}.
@burblebee burblebee added the big label Jun 18, 2014
@jensmaurer
Copy link
Member

The fun part of this is that some definitions use \term and have an \indextext next to it. I agree \defnx is technically superior, though. For what it's worth, there are 684 mentions of \term, which should probably all become either \defn or \placeholder or something else.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 17, 2016

I think PR #980 addresses part of that. It's pending review.

jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 17, 2016
@jensmaurer
[basic] Replace \term with \defnx as appropriate
f417a9b 
Partially addresses cplusplus#329.
jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 17, 2016
@jensmaurer
[basic] Replace \term with \defnx as appropriate
a9e8312 
Partially addresses cplusplus#329.
@jensmaurer jensmaurer mentioned this issue Nov 17, 2016
Merged
jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 17, 2016
@jensmaurer
[intro] Replace \term with \placeholder or \defn as appropriate
862cfac 
Partially addresses cplusplus#329.
@jensmaurer jensmaurer mentioned this issue Nov 17, 2016
Merged
@jensmaurer
Copy link
Member

I would have been nice to mention #329 in PR #980 to avoid duplicate work...

tkoeppe pushed a commit that referenced this issue Nov 17, 2016
@jensmaurer @tkoeppe
[basic] Replace \term with \defnx as appropriate (#1061)
6e498da 
Partially addresses #329.
tkoeppe pushed a commit that referenced this issue Nov 17, 2016
@jensmaurer @tkoeppe
[intro] Replace \term with \placeholder or \defn as appropriate (#1062)
0838cf9 
Partially addresses #329.
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 17, 2016

That's true. I find it useful to browser the pending pull requests periodically to see what's pending. Feel free to edit pending PRs with issue links as you find them.

jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 18, 2016
@jensmaurer
[lex] Replace \term with \placeholder or \defn as appropriate
7e06048 
Partially addresses cplusplus#329.
@jensmaurer jensmaurer mentioned this issue Nov 18, 2016
Merged
tkoeppe pushed a commit that referenced this issue Nov 18, 2016
@jensmaurer @tkoeppe
[lex] Replace \term with \placeholder or \defn as appropriate (#1067)
55af844 
Partially addresses #329.
tkoeppe pushed a commit that referenced this issue Nov 18, 2016
@jensmaurer @tkoeppe
[lex] Replace \term with \placeholder or \defn as appropriate (#1067)
b8e0e09 
Partially addresses #329.
jensmaurer added a commit to jensmaurer/draft that referenced this issue Dec 21, 2016
@jensmaurer
[except] Replace \term and \textit
daef833 
with \grammarterm or \defn/x as appropriate.

Also add an index entry.

Partially addresses cplusplus#701.
Partially addresses cplusplus#329.
@jensmaurer jensmaurer mentioned this issue Dec 21, 2016
Merged
jensmaurer added a commit to jensmaurer/draft that referenced this issue Jan 3, 2017
@jensmaurer
[except] Replace \term and \textit
b84cf4c 
with \grammarterm or \defn/x as appropriate.

Also add an index entry.

Partially addresses cplusplus#701.
Partially addresses cplusplus#329.
jensmaurer added a commit to jensmaurer/draft that referenced this issue Jan 10, 2017
@jensmaurer
[except] Replace \term and \textit
2cceca4 
with \grammarterm or \defn/x as appropriate.

Also add an index entry.

Partially addresses cplusplus#701.
Partially addresses cplusplus#329.
tkoeppe pushed a commit that referenced this issue Jan 11, 2017
@jensmaurer @tkoeppe
[except] Replace \term and \textit with \grammarterm, \defn or \defnx…
232e3f4 
… as appropriate. (#1286)

Also add an index entry.

Partially addresses #701.
Partially addresses #329.
@jensmaurer jensmaurer mentioned this issue Jan 16, 2017
Merged
@Eelis Eelis mentioned this issue Jul 16, 2017
Merged
This was referenced Dec 2, 2017
Closed
Merged
Merged
Merged
Merged
Merged
@jensmaurer jensmaurer mentioned this issue Feb 25, 2018
Merged
@jensmaurer jensmaurer mentioned this issue Feb 25, 2018
Merged
@jensmaurer jensmaurer mentioned this issue May 24, 2018
Open
@Eelis
Copy link
Contributor

Eelis commented Nov 17, 2018

Update to quantify the "big" label: there's now 216 uses of \term left.

@Eelis Eelis mentioned this issue Nov 12, 2019
Merged
@jwakely
Copy link
Member

jwakely commented Nov 12, 2019

As I mentioned in #3435, these look wrong:

declarations.tex:Except for this special case, a parameter shall not have type \term{cv}
declarations.tex:if any of its \term{namespace-definition}{s} is exported,
expressions.tex:\tcode{std::type_info} or \tcode{const} \term{name} where \term{name} is an
locales.tex:\term{explicit},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
big An issue causing a large set of changes, scattered across most of the text.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Eelis @jwakely @tkoeppe @burblebee @jensmaurer