Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indefinite articles before grammatical productions #3291

Closed
wants to merge 3 commits into from

Conversation

sdkrystian
Copy link
Contributor

Pretty simple grammatical fix

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 11, 2019

I don't think the status quo is wrong here. "A form of if statement" seems like a correct way to refer to the different forms.

@sdkrystian
Copy link
Contributor Author

sdkrystian commented Oct 11, 2019

@tkoeppe I feel that an indefinite article here is needed, since we are referring to a construct, seeing as we already use definite articles when referring to specific instances of a construct. It also reads a lot smoother.

However, if the consensus if that its fine, then we should make the use consistent.

@jensmaurer
Copy link
Member

It seems to me the status quo is fine here. "In the first form of mutiny, all participants are incarcerated. In the second form of mutiny, all participants are beheaded." sounds reasonable.

@jensmaurer jensmaurer closed this Oct 11, 2019
@sdkrystian
Copy link
Contributor Author

@jensmaurer Alright. Should we atleast make the use consistent? For example, http://eel.is/c++draft/dcl.dcl#dcl.init-16.5 uses an indefinite article before the noun, but http://eel.is/c++draft/dcl.dcl#dcl.init-1.sentence-2 doesn't.

@jensmaurer
Copy link
Member

jensmaurer commented Oct 12, 2019

So, this turned into a consistency question, and the suggested pull request here actually does not address the consistency issue to the extent we know about it.

@jensmaurer jensmaurer reopened this Oct 12, 2019
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 12, 2019
@sdkrystian
Copy link
Contributor Author

@jensmaurer I'll change the PR accordingly.

@sdkrystian sdkrystian changed the title [stmt.if] Add "an" in front of "if statement" No indefinite articles before grammatical productions Oct 12, 2019
@zygoloid
Copy link
Member

"the second form of if statement" is talking about the general category of if statements, which have multiple forms, so omitting the indefinite article there seems correct (we're not talking about a single if statement that has multiple forms, so "an" is inappropriate). The cases affected by the revised pull request are talking about a specific instance of a grammar production, and for those cases, the indefinite article is appropriate.

I don't think there's a systematic problem here, and I'm unconvinced that any of the changes so far are improvements.

@zygoloid zygoloid closed this Oct 21, 2019
@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants