Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[duration.cast, time.point.cast] Better subclause names #3298

Closed
JohelEGP opened this issue Oct 15, 2019 · 5 comments · Fixed by #3302
Closed

[duration.cast, time.point.cast] Better subclause names #3298

JohelEGP opened this issue Oct 15, 2019 · 5 comments · Fixed by #3302
Assignees
@jensmaurer

Comments

@JohelEGP
Copy link
Contributor

These subclauses are named after the entities they originally described, duration_cast and time_point_cast. Since C++17, they also describe floor, ceil and round entities, so better subclause names are in order. Perhaps also consider folding the single-entity subclause [time.duration.alg] "Algorithms" holding abs into [duration.cast].
@jwakely
Copy link
Member

jwakely commented Oct 15, 2019

Does the benefit of renaming these outweigh the cost though?

@JohelEGP
Copy link
Contributor Author

I wonder. I couldn't think of any reasonable suggestion. I noticed this when I couldn't find the rounding functions in the table on contents.

@JohelEGP
Copy link
Contributor Author

The best I could think of was moving the rounding functions to their own subclause, but that'd create more single-item subclauses, which are discouraged.

@jwakely
Copy link
Member

jwakely commented Oct 15, 2019

Use the index or the search function in your favourite pdf reader.

@jensmaurer
Copy link
Member

jensmaurer commented Oct 16, 2019 •
edited

I agree the heading "duration_cast" is misleading if the respective subclause has more similar functions. Something like "Conversions" sounds plausible.

@jensmaurer jensmaurer mentioned this issue Oct 16, 2019
Merged
@jensmaurer jensmaurer self-assigned this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[time.duration.cast,time.point.cast] Rename subclause to 'Conversions'. jensmaurer/draft
3 participants
@jwakely @JohelEGP @jensmaurer