Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-unsigned-like and make-unsigned-like-t are too similar #3300

Closed
CaseyCarter opened this issue Oct 15, 2019 · 1 comment
Closed

make-unsigned-like and make-unsigned-like-t are too similar #3300

CaseyCarter opened this issue Oct 15, 2019 · 1 comment
Assignees
@CaseyCarter

Comments

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Oct 15, 2019 •
edited

[ranges.syn]/1 defines an exposition only function make-unsigned-like and an exposition-only metafunction make-unsigned-like-t. These two names are hard to distinguish, doubly so with an argument list:

make-unsigned-like(meow) vs. make-unsigned-like-t(woof).

It would help somewhat if make-unsigned-like-t were treated as an exposition-only alias template:

make-unsigned-like(meow) vs. make-unsigned-like-t<woof>

but ideally the names themselves should be more distinct as well. @jwakely suggests renaming make-unsigned-like to as-unsigned-like or to-unsigned-like, which preserves the intended similarity between make-unsigned-like-t and make_unsigned_t.

(As discussed in #3299 (comment)).
@CaseyCarter CaseyCarter mentioned this issue Oct 15, 2019
Merged
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 16, 2019
@jensmaurer
Copy link
Member

Editorial meeting: When we have exposition-only foo and foo-t, their relationship should be the same as any other bar and bar_t. That's not the case here. Rename "make-unsigned-like" to "to-unsigned-like".

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 21, 2019
CaseyCarter added a commit to CaseyCarter/draft that referenced this issue Oct 21, 2019
@CaseyCarter
[ranges] Rename make-unsigned-like to to-unsigned-like
4430b41 
Resolves cplusplus#3300.
@CaseyCarter CaseyCarter mentioned this issue Oct 21, 2019
Merged
CaseyCarter added a commit to CaseyCarter/draft that referenced this issue Nov 25, 2019
@CaseyCarter
[ranges] Rename make-unsigned-like to to-unsigned-like
d534964 
Resolves cplusplus#3300.
CaseyCarter added a commit to CaseyCarter/draft that referenced this issue Jan 24, 2020
@CaseyCarter
[ranges] Rename make-unsigned-like to to-unsigned-like
a06d0b2 
Resolves cplusplus#3300.
CaseyCarter added a commit to CaseyCarter/draft that referenced this issue Jan 24, 2020
@CaseyCarter
[ranges] Rename make-unsigned-like to to-unsigned-like
4367e71 
Resolves cplusplus#3300.
@burblebee burblebee mentioned this issue Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaseyCarter CaseyCarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CaseyCarter @jensmaurer