Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[support.srcloc.class] Highlight unspecified properties #3309

Merged
merged 1 commit into from Dec 2, 2019
Merged

[support.srcloc.class] Highlight unspecified properties #3309

merged 1 commit into from Dec 2, 2019

Conversation

jensmaurer
Copy link
Member

of the source_location constructors and copy assignment
operators.

Fixes #3170.

jwakely
jwakely reviewed Oct 21, 2019
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially be misread to say that they are either trivial or constexpr, but it's unspecified which. That reading would be obviously incorrect, but that doesn't always stop people misreading things!

@jensmaurer
Copy link
Member Author

@jwakely, what about "trivial and/or constexpr"?

@jwakely
Copy link
Member

jwakely commented Oct 22, 2019

Yes, I prefer that.

@jensmaurer
[support.srcloc.class] Highlight unspecified properties
94d8dbc 
of the source_location constructors and copy assignment
operators.
@jensmaurer
Copy link
Member Author

Updated accordingly.

@jensmaurer jensmaurer merged commit 1b0c11b into cplusplus:master Dec 2, 2019
@jensmaurer jensmaurer deleted the c14 branch December 2, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[support.srcloc] It's underspecified whether copy/move functions of source_location are constexpr or not
2 participants
@jensmaurer @jwakely