Cleanup make-unsigned-like #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
I'm ok with this change, although I'd like to point out that making "make-unsigned-like-t" an alias template was not specifically approved by the editorial meeting.
It might actually be a good idea to gravitate towards alias template syntax for exposition-only type metafunctions.
jensmaurer
added
the
needs rebase
|
@CaseyCarter , this needs a rebase. |
So rebased. |
|
Rebased again. |
jwakely
approved these changes
Jan 24, 2020
jensmaurer
removed
the
needs rebase
|
Uh, it seems the other check-in created a conflict here, yet again. @CaseyCarter , please rebase. |
jensmaurer
added
the
needs rebase
...instead of an exposition-only macro. In other words, it's used as `make-unsigned-like-t<meow>` instead of `make-unsigned-like-t(meow)`.
|
Rebased harder. |
jensmaurer
removed
the
needs rebase
burblebee
pushed a commit
that referenced
this pull request
Feb 23, 2020
zygoloid
pushed a commit
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...per the direction of #3300. This PR consists of three commits:
make-unsigned-liketoto-unsigned-likemake-unsigned-like-tfrom an exposition-only macro (invoked with parentheses) into an exposition-only alias template ("invoked" with angle brackets)xof typeX,to-unsigned-like(x)is..." to "For an expressionx".I believe the change from
()to<>in the second commit makes the occurrences ofmake-unsigned-like-tread better in the text - as well as increasing the intentional similarity withmake_unsigned_t<meow>- but this change doesn't appear to have been discussed in the editorial meeting.