Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basic.scope.class] Reinstate a qualification that was lost in 0e26279b88c3b8b0a09babdeec8418d383f07419. #3312

Merged
merged 1 commit into from Oct 21, 2019

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Oct 21, 2019

Without the introductory sentence that was deleted by that commit, we need to say explicitly that we are talking about a declaration in a class.

See also discussion on #1137.

Without the introductory sentence that was deleted by that commit, we need to say explicitly that we are talking about a declaration _in a class_.
@zygoloid zygoloid merged commit 9af3fc2 into cplusplus:master Oct 21, 2019
@tkoeppe tkoeppe deleted the basicclass branch October 21, 2019 20:18
@languagelawyer
Copy link
Contributor

Why we don't need similar fix in the previous paragraph?

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Oct 21, 2019

The next paragraph is just an example, isn't it?

@languagelawyer
Copy link
Contributor

The previous, not the next. The third paragraph also speaks about declarations whose scope extends to or past the end of a class definition. (Also the word "definition" is missing at the end).

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Oct 21, 2019

Ah, sorry, I see. (I had somehow misread the original message as "fourth and fifth", sorry!) So for the previous paragraph, we can say "hides a declaration of the same name in that class"?

The "definition" was also absent from the original introductory paragraph, do you think it matters?

@languagelawyer
Copy link
Contributor

I had somehow misread the original message as "fourth and fifth", sorry!

It was originally saying "fourht and fifth", this was my mistake, sorry.

So for the previous paragraph, we can say "hides a declaration of the same name in that class"?
The "definition" was also absent from the original introductory paragraph, do you think it matters?

Let me redirect this to @zygoloid

@zygoloid
Copy link
Member

@languagelawyer For the third paragraph, do you have an example in mind? I think the slightly broader wording we have here is equivalent to the more-restrictive version. In fact, paragraph 3 seems to be entirely redundant, since it follows from [basic.lookup.unqual]p1 and p8.

It's also unlikely to be worth spending much time on editorial improvements here, since http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1787r2.html is replacing all this wording and is likely to land next meeting (or maybe the one after, depending on how fast CWG gets through the NB comments).

@languagelawyer
Copy link
Contributor

@zygoloid No, I don't have an example. I doubt there is an example even for the fourth paragraph.
I've just pointed to the fact that normative wording has been changed without CWG review/approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants