Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird sentence in [ostream] #3333

Closed
gennaroprota opened this issue Oct 25, 2019 · 3 comments · Fixed by #3784
Closed

Weird sentence in [ostream] #3333

gennaroprota opened this issue Oct 25, 2019 · 3 comments · Fixed by #3784
Assignees
@jwakely

Comments

@gennaroprota
Copy link

Quoting from [ostream]:

"If one of these called functions throws an exception, then unless
explicitly noted otherwise the output function sets badbit in error
state. If badbit is on in exceptions(), the output function rethrows
the exception without completing its actions, otherwise it does not
throw anything and treat as an error. "

"and treat as an error" seems wrong; should it be "and treats it as
an error"? If that is the case, I'd say that it adds nothing useful and
should be removed.
@cubbimew
Copy link
Contributor

cubbimew commented Nov 6, 2019

FWIW, similar passage in [istream] ends in a more sensible "otherwise it does not throw anything and proceeds as if the called function had returned a failure indication."

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Dec 15, 2019
@jensmaurer
Copy link
Member

Editorial meeting: Assign to @jwakely.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Feb 10, 2020
@jwakely
Copy link
Member

jwakely commented Feb 20, 2020 •
edited

The wording seems very similar to Issues 27-406 and 27-504 in N0827. I don't know when or why the wording in [istream] and [ostream] diverged.

I think we should improve "sets badbit in error state" in both places.

It seems like an improvement to make both places say "proceeds as if the called function had returned a failure indication."

jwakely added a commit to jwakely/draft that referenced this issue Feb 21, 2020
@jwakely
[ostream] Fix poor grammar to be consistent with [istream]
3efd699 
Also fix grammar in [istream], [istream.extractors] and
[ostream.inserters] to refer to "*the* error state", and use "is set in"
when talking about a bitmask element being set in a value of a bitmask
type.

Fixes cplusplus#3333
@jwakely jwakely mentioned this issue Feb 21, 2020
Merged
jwakely added a commit to jwakely/draft that referenced this issue Feb 21, 2020
@jwakely
[ostream] Fix poor grammar to be consistent with [istream]
e2c0299 
Also fix grammar in [istream], [istream.extractors] and
[ostream.inserters] to refer to "*the* error state", and use "is set in"
when talking about a bitmask element being set in a value of a bitmask
type.

Fixes cplusplus#3333
zygoloid pushed a commit that referenced this issue Mar 13, 2020
@jwakely @zygoloid
[ostream] Fix poor grammar to be consistent with [istream]
b7c0d71 
Also fix grammar in [istream], [istream.extractors] and
[ostream.inserters] to refer to "*the* error state", and use "is set in"
when talking about a bitmask element being set in a value of a bitmask
type.

Fixes #3333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwakely jwakely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ostream] Fix poor grammar to be consistent with [istream] jwakely/draft
4 participants
@jwakely @gennaroprota @cubbimew @jensmaurer