Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dcl.inline] Function parameters shouldn't be inline #3346

Closed
wants to merge 1 commit into from

Conversation

sdkrystian
Copy link
Contributor

@sdkrystian sdkrystian commented Oct 28, 2019

It is nonsensical for function parameters to be declared inline, as the wording in [dcl.inline] would be meaningless for function parameter. A function parameter does is not declared in block scope, so http://eel.is/c++draft/dcl.inline#5 doesn't apply.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 29, 2019
@jensmaurer
Copy link
Member

Maybe changing p5 to say "on a function parameter or block scope declaration" is better? Is this editorial to start with?

@sdkrystian
Copy link
Contributor Author

sdkrystian commented Oct 29, 2019

Function parameters have no linkage, so it being an inline variable would have no effect whatsoever. I feel that the intent here is pretty clear. As for the wording, I made it congruent to how it is specified for the storage class specifiers.

If it is decided that this is not editorial, I can submit a DR.

@jensmaurer jensmaurer added cwg Issue must be reviewed by CWG. and removed decision-required A decision of the editorial group (or the Project Editor) is required. labels Nov 4, 2019
@jensmaurer
Copy link
Member

jensmaurer commented Nov 4, 2019

Editorial meeting: Please submit a core issue. Other uses of "block scope" should probably also extend to "function parameter scope".

@sdkrystian
Copy link
Contributor Author

Submitted as issue 2441

@sdkrystian sdkrystian closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cwg Issue must be reviewed by CWG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants