[class.copy.assign] Remove semicolon in 'of the form' phrase. #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves consistency with other such phrases. Fixes late comment CH 02.
tkoeppe
reviewed
Nov 1, 2019
| @@ -1919,7 +1919,7 @@ | |||
| \pnum | |||
| The implicitly-declared move assignment operator for a class \tcode{X} will have the form | |||
| \begin{codeblock} | |||
| X& X::operator=(X&&); | |||
| X& X::operator=(X&&) | |||
There was a problem hiding this comment.
This is awkward, as it now leaves the sentence unfinished.
Looking at the next paragraph, I see that there we use a _text_semicolon to structure the sentence. Do we have similar options here? Otherwise add a colon after "have the form"?
There was a problem hiding this comment.
This is also the case for [class.copy.ctor]p7 and p9, [class.copy.assign]p2, and [class.dtor]p3.
The idea of this change (and the request of the NB comment as I understand it) is just to get to somewhere consistent. We should tackle any other changes / improvements here as separate editorial issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves consistency with other such phrases.
Fixes late comment CH 02.
Fixes cplusplus/nbballot#376