Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thread.jthread.class] Namespace not closed #3363

Merged
merged 1 commit into from Nov 5, 2019
Merged

[thread.jthread.class] Namespace not closed #3363

merged 1 commit into from Nov 5, 2019

Conversation

sebastianrath
Copy link
Contributor

@sebastianrath sebastianrath commented Nov 2, 2019 •
edited

Minor issue, my parser failed to parse the jthread codeblock because the std namespace is not closed.

@JohelEGP
Copy link
Contributor

JohelEGP commented Nov 2, 2019

Nice find.
According to https://github.com/cplusplus/draft/wiki/How-to-submit-an-editorial-issue, you need to prefix the PR title and commit message with [thread.jthread.class].

@sebastianrath sebastianrath changed the title Namespace not closed [thread.jthread.class] Namespace not closed Nov 2, 2019
@sebastianrath
Copy link
Contributor Author

sebastianrath commented Nov 5, 2019 •
edited

Hi, any updates on this? It's a minor fix

@jwakely jwakely merged commit ee28791 into cplusplus:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebastianrath @JohelEGP @jwakely