Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1872R0 span should have size_type, not index_type #3446

Merged
merged 1 commit into from Nov 21, 2019
Merged

P1872R0 span should have size_type, not index_type #3446

merged 1 commit into from Nov 21, 2019

Conversation

zygoloid
Copy link
Member

@zygoloid zygoloid commented Nov 13, 2019 •
edited by jensmaurer

Fixes #3407.
Fixes cplusplus/nbballot#236.
Fixes cplusplus/nbballot#241.
Fixes cplusplus/nbballot#244.

Fixes cplusplus/papers#622

Also fixes NB FR 240, US 245, and PL 248 (C++20 CD).

@jensmaurer jensmaurer added this to the post-2019-11 milestone Nov 13, 2019
jensmaurer
jensmaurer approved these changes Nov 16, 2019
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zygoloid
P1872R0 span should have size_type, not index_type
c2dea2e 
Also fixes NB FR 240, US 245, and PL 248 (C++20 CD).
@zygoloid zygoloid merged commit 38e5d6d into master Nov 21, 2019
@jensmaurer jensmaurer deleted the motions-2019-11-lwg-4 branch February 18, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2019-11
2 participants
@zygoloid @jensmaurer