remove unnecessary <T> from valarray.
#345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faithandbrave
changed the title
<T> to valarray::operator=(initializer_list<T>)
|
My preference is to remove redundant template argument lists, it makes the code much easier to read, see e.g. ced4bbd |
|
OK, I'll fix this pull request. |
|
It might be worth waiting to see what @zygoloid and others think |
|
My preference is to leave out the template argument lists whenever naming the injected-class-name. Listing them explicitly makes the reader wonder whether they're somehow different. |
|
I confirmed consensus. I'll remove |
…into fix_missing_t Conflicts: source/numerics.tex
|
I re-pull requested. Please check the change. |
faithandbrave
changed the title
<T> from valarray.
| @@ -6885,7 +6885,7 @@ | |||
| \indexlibrary{\idxcode{operator=}!\idxcode{valarray}}% | |||
| \indexlibrary{\idxcode{valarray}!\idxcode{operator=}}% | |||
| \begin{itemdecl} | |||
| valarray& operator=(initializer_list<T> il); | |||
| valarray<T>& operator=(initializer_list<T> il); | |||
There was a problem hiding this comment.
This <T> should be removed (i.e., this line shouldn't be part of the diff).
There was a problem hiding this comment.
Thanks for your review. I removed the <T>.
|
Thanks - I committed a squashed merge of your changes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
<T>of return type for consistency.