Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1456R1 Move-only views #3453

Merged
merged 3 commits into from Nov 21, 2019
Merged

P1456R1 Move-only views #3453

merged 3 commits into from Nov 21, 2019

Conversation

zygoloid
Copy link
Member

@zygoloid zygoloid commented Nov 14, 2019 •
edited by jensmaurer

@zygoloid zygoloid added this to the post-2019-11 milestone Nov 14, 2019
@jensmaurer
Copy link
Member

Please augment the commit message to add references to the NB ballot comments mentioned above.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 14, 2019
@JohelEGP
Copy link
Contributor

JohelEGP commented Nov 14, 2019 •
edited

Missing changes to base: take_while_view, drop_view, drop_while_view and elements_view.

Edit: I see that this is part of a bigger change, and maybe they're taken care of. P1862 particularly seems to add the base changes to some iterators of the views.

@JohelEGP JohelEGP mentioned this pull request Nov 14, 2019
Closed
@cor3ntin
Copy link
Contributor

@JohelEGP No, you are right, all views with a base member function should provide a rvale qualified overload - P1862 does that to iterators ( and iterators only ) @CaseyCarter

@CaseyCarter
Copy link
Contributor

Missing changes to base: take_while_view, drop_view, drop_while_view and elements_view.

Yes, "Change [range.transform.view], [range.take.view], [range.common.view], and [range.reverse.view] similarly" in P1456 is missing the range adaptors added by P1035. Are we willing to construe P1456 as providing editorial instructions to make similar changes to all such range adaptors, or shall I submit an LWG issue to make this same change to these four that were missed?

@zygoloid
Copy link
Member Author

@CaseyCarter I think the "Proposal" section gives us sufficient motivation to consider this an editorial fix to the wording as moved:

we propose that each such base() member be replaced to by two overloads: a const-qualified overload that requires the type of the underlying view to model CopyConstructible, and a &&-qualified overload that extracts the underlying view from the adaptor

(especially with you as a paper author telling us this was indeed the intent!).

@zygoloid zygoloid removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 16, 2019
JohelEGP
JohelEGP suggested changes Nov 16, 2019
View reviewed changes
papers/nxxxx.md Outdated Show resolved Hide resolved
jensmaurer
jensmaurer approved these changes Nov 16, 2019
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
@zygoloid
P1456R1 Move-only views
dc8a603 
Fixes NB GB 277 and FR 281, and partially fixes US 253 and GB 270 (C++20 CD).
@zygoloid
[range.adaptors] Extend the changes from P1456R1 to also apply to
1dd384a 
take_while_view, drop_view, drop_while_view, and elements_view.

These are covered by the direction proposed in the paper, but were
inadvertently omitted from the list of things to change in the wording.
@zygoloid
[range.view] Make the requirement for constant-time move operations and
6d9db6a 
destruction explicit in the description of when a type models view.
@zygoloid zygoloid merged commit c1182ca into master Nov 21, 2019
@jensmaurer jensmaurer deleted the motions-2019-11-lwg-11 branch February 18, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@JohelEGP JohelEGP JohelEGP requested changes

@jensmaurer jensmaurer jensmaurer approved these changes

@jwakely jwakely Awaiting requested review from jwakely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2019-11
5 participants
@zygoloid @jensmaurer @JohelEGP @cor3ntin @CaseyCarter